Repository navigation
refactor: resolve the site name and addresses in one place - #528
Merged
Merged
Conversation
Page titles, social cards, structured data and SEO output now share the site name and URL resolution rules. The site name still prefers `website.title` in the generated `_quarto.yml`, then the configured display name, then the package name. Canonical URLs still prefer `seo.canonical.base_url`, then `site_url`, then the repository's GitHub Pages address. Copying the default social card image into the site and addressing it now lives with the other social card code. It still warns about a missing local image, and builds, raw custom pages and the `seo` command produce the same output as before.
📚 Preview this PR's docs locallyFetch the just-built site and open it in your browser: # this exact build
great-docs preview --run 41811061009
# or always the latest build for this PR
great-docs preview --pr 528Auth & tips
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gathers the site name, the configured site URL and the preferred address for canonical links into one value, built from the configuration, the repository and the generated
_quarto.yml. Page titles, social cards, structured data, raw custom pages andgreat-docs seoused to ask the build object for each value through separate methods, each of which detected the repository again. Copying the default social card image into the site now lives with the rest of the social card code. No output changes.